Added UTs for GetAllTribes, GetTotalTribes & GetListedTribes #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elraphty
requested changes
Feb 23, 2024
| rctx := chi.NewRouteContext() | ||
| tagVals := pq.StringArray{"tag1", "tag4", "tag7"} | ||
| tags := strings.Join(tagVals, ",") | ||
| rctx.URLParams.Add("tags", tags) |
There was a problem hiding this comment.
The tags should be in URL query not Params
| rctx := chi.NewRouteContext() | ||
| tagVals := pq.StringArray{} | ||
| tags := strings.Join(tagVals, ",") | ||
| rctx.URLParams.Add("tags", tags) |
There was a problem hiding this comment.
The tags should be in URLQuery, not URLParams
| @@ -10,12 +10,13 @@ func TribeRoutes() chi.Router { | |||
| r := chi.NewRouter() | |||
| tribeHandlers := handlers.NewTribeHandler(db.DB) | |||
| r.Group(func(r chi.Router) { | |||
| r.Get("/", handlers.GetListedTribes) | |||
| r.Get("/{tags}", tribeHandlers.GetListedTribes) | |||
There was a problem hiding this comment.
Why change the URL and add tags params to it, the tags come come the URL query.
This reverts commit 9c0ca29.
|
Created another pull request to fix this.
…On Fri, Feb 23, 2024 at 3:43 PM Raphael Osaze Eyerin < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In handlers/tribes_test.go
<#1555 (comment)>
:
> +func TestGetListedTribes(t *testing.T) {
+ mockDb := mocks.NewDatabase(t)
+ tHandler := NewTribeHandler(mockDb)
+
+ t.Run("should only return tribes associated with a passed tag query", func(t *testing.T) {
+ rr := httptest.NewRecorder()
+ handler := http.HandlerFunc(tHandler.GetListedTribes)
+ expectedTribes := []db.Tribe{
+ {UUID: "1", Name: "Tribe 1", Tags: pq.StringArray{"tag1", "tag2", "tag3"}},
+ {UUID: "2", Name: "Tribe 2", Tags: pq.StringArray{"tag4", "tag5"}},
+ {UUID: "3", Name: "Tribe 3", Tags: pq.StringArray{"tag6", "tag7", "tag8"}},
+ }
+ rctx := chi.NewRouteContext()
+ tagVals := pq.StringArray{"tag1", "tag4", "tag7"}
+ tags := strings.Join(tagVals, ",")
+ rctx.URLParams.Add("tags", tags)
The tags should be in URL query not Params
------------------------------
In handlers/tribes_test.go
<#1555 (comment)>
:
> + assert.EqualValues(t, expectedTribes, returnedTribes)
+
+ })
+
+ t.Run("should return all tribes when no tag queries are passed", func(t *testing.T) {
+ rr := httptest.NewRecorder()
+ handler := http.HandlerFunc(tHandler.GetListedTribes)
+ expectedTribes := []db.Tribe{
+ {UUID: "1", Name: "Tribe 1", Tags: pq.StringArray{"tag1", "tag2", "tag3"}},
+ {UUID: "2", Name: "Tribe 2", Tags: pq.StringArray{"tag4", "tag5"}},
+ {UUID: "3", Name: "Tribe 3", Tags: pq.StringArray{"tag6", "tag7", "tag8"}},
+ }
+ rctx := chi.NewRouteContext()
+ tagVals := pq.StringArray{}
+ tags := strings.Join(tagVals, ",")
+ rctx.URLParams.Add("tags", tags)
The tags should be in URLQuery, not URLParams
------------------------------
In routes/tribes.go
<#1555 (comment)>
:
> @@ -10,12 +10,13 @@ func TribeRoutes() chi.Router {
r := chi.NewRouter()
tribeHandlers := handlers.NewTribeHandler(db.DB)
r.Group(func(r chi.Router) {
- r.Get("/", handlers.GetListedTribes)
+ r.Get("/{tags}", tribeHandlers.GetListedTribes)
Why change the URL and add tags params to it, the tags come come the URL
query.
—
Reply to this email directly, view it on GitHub
<#1555 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN7TITLIR3CW7KLB6RCCCLDYVCFGRAVCNFSM6AAAAABDVZGHCOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJYGAYTSNRYG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Issue number 1527
#1527
Type of change
Added test to tribes.go for
GetAllTribes,GetListedTribes,GetTotalTribesPlease delete options that are not relevant.
Checklist before requesting a review